Increase max number of log files to 20. #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4856
This is a quick fix for the request at #4856.
I only increases statically the numbe rof log files from 10 to 20. As we have too many bugs atm I think that helps to find the issues and can be reverted later once not needed anymore, and/or implemented with a setting in the preferences. As log is setup very early in the setup I am not sure that will be that easy... the propery file need to be used probably.
We should use a high value as default, as otherwise once a bug happen it might not help if it is older and already removed.
No hard need to get into 1.5.1 but as its that low risk and have be helpful for future debugging I recommend to get it in as well.